[libvirt] [PATCH v5 10/23] src: rewrite driver name checker in Python

Ján Tomko jtomko at redhat.com
Wed Nov 20 06:52:47 UTC 2019

On Mon, Nov 11, 2019 at 02:38:13PM +0000, Daniel P. Berrangé wrote:
>As part of an goal to eliminate Perl from libvirt build tools,
>rewrite the check-drivername.pl tool in Python.
>This was mostly a straight conversion, manually going line-by-line
>to change the syntax from Perl to Python. Thus the overall structure
>of the file and approach is the same.
>In testing though it was discovered the existing code was broken
>since it hadn't been updated after driver.h was split into many
>files. Since the old code is being thrown away, the fix was done
>as part of the rewrite rather than split into a separate commit.

It's nice that we haven't broken anything in those years :)

>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> Makefile.am                 |   1 +
> scripts/check-drivername.py | 114 ++++++++++++++++++++++++++++++++++++
> src/Makefile.am             |  18 ++++--
> src/check-drivername.pl     |  83 --------------------------
> 4 files changed, 129 insertions(+), 87 deletions(-)
> create mode 100644 scripts/check-drivername.py
> delete mode 100755 src/check-drivername.pl

Reviewed-by: Ján Tomko <jtomko at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191120/f7b1d8bf/attachment-0001.sig>

More information about the libvir-list mailing list