[libvirt] [PATCH 8/9] wip: start virtiofsd

[Ján Tomko]

On Mon, Nov 04, 2019 at 10:06:40AM +0100, Stefan Hajnoczi wrote:
>On Fri, Nov 1, 2019 at 1:18 PM Ján Tomko <jtomko at redhat.com> wrote:
>> +    if (qemuSecuritySetDaemonSocketLabel(driver->securityManager, vm->def) < 0)
>> +        goto cleanup;
>> +    fd = qemuOpenChrChardevUNIXSocket(chrdev);
>> +    if (fd < 0)
>> +        goto cleanup;
>> +    if (qemuSecurityClearSocketLabel(driver->securityManager, vm->def) < 0)
>> +        goto cleanup;
>
>qemuSecurityClearSocketLabel() is not called in the
>qemuOpenChrChardevUNIXSocket() error code path.  Is this correct?
>

That's an oversight, thanks for catching that.

>> +static void
>> +qemuExtVirtioFSdStop(virQEMUDriverPtr driver,
>> +                     virDomainObjPtr vm,
>> +                     virDomainFSDefPtr fs)
>> +{
>
>The daemon stops automatically when the vhost-user socket is closed by
>QEMU.  Is it necessary to implement an explicit stop function?
>

I hope not, but thought it was better to have it than possibly leaving
leftover daemons.

Jano

>Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191120/c73d5029/attachment-0001.sig>