[libvirt] [jenkins-ci] guests: Add support for openSUSE Leap 15.1

[Jim Fehlig]

On 11/20/19 2:16 PM, Fabiano Fidêncio wrote:
> On Wed, Nov 20, 2019 at 8:44 PM Jim Fehlig <jfehlig at suse.com> wrote:
>>
>> On 11/19/19 11:56 PM, Fabiano Fidêncio wrote:
>>> On Wed, Nov 20, 2019 at 12:01 AM Jim Fehlig <jfehlig at suse.com> wrote:
>>>>
>>>> On 11/19/19 3:32 AM, Andrea Bolognani wrote:
>>>>> On Tue, 2019-11-19 at 00:21 +0000, Jim Fehlig wrote:
>>
>> [...]
>>
>>>>>> +++ b/guests/host_vars/libvirt-opensuse-15.1/main.yml
>>>>>> +package_format: 'rpm'
>>>>>> +package_manager: 'zypper'
>>>>>> +os_name: 'openSUSE'
>>>>>> +os_version: '15.1'
>>>>>
>>>>> So, about the naming.
>>>>>
>>>>> What I would have done here is
>>>>>
>>>>>      os_name: 'OpenSUSE'
>>>>>      os_version: '15'
>>>>>
>>>>> The intial capital letter in os_name goes against the actual branding
>>>>> for openSUSE so I'm not perfectly happy with it, but on the other
>>>>> hand it's very useful when defining mappings because package formats
>>>>> all start with a lowercase letter and all OS names start with an
>>>>> uppercase letter. So I would try to stick with that convention.
>>>>
>>>> Ok, no problem.
>>>>
>>>>> As for os_version, if you look at all existing entries we use the
>>>>> major version number only: eg. we have CentOS7 instead of CentOS7.7
>>>>> and FreeBSD12 instead of FreeBSD12.1: this makes sense because, as
>>>>> the guest gets updated over time, it will naturally pick up the
>>>>> latest minor release. Will this work for openSUSE too?
>>>>
>>>> I suppose so. Although for example Leap 15.2 will have a different kernel (5.3.
>>>> vs 4.12), different install path
>>>> (http://download.opensuse.org/distribution/leap/15.2/repo/oss/), etc. Is that okay?
>>>
>>> It depends a lot on what's the OpenSUSE policy of its distro. Once
>>> 15.2 is out, what happens to 15.1? Is this just a "minor" update? Will
>>> 15.1 still be supported or are people expected to just update /
>>> upgrade to 15.2?
>>
>> 15.1 will continue to be actively supported alongside 15.2 for six months after
>> the release of 15.2. The lifecycle is described here
>>
>> https://en.opensuse.org/Lifetime
>>
>> Perhaps it is best to just support the latest Leap release plus openSUSE
>> Tumbleweed? I.e. I send a patch to replace the 15.1 machine with 15.2 once it is
>> released.
> 
> I'd adopt the same policy we have for other distros. Support the last
> two releases (as in, Fedora 30 and Fedora 31).
> 
> Leap seems to fit in the "Fedora" case. Thus, I'd keep 15.1, 15.2, 15.3, ...

But how to name those? Is a '.' in the name problematic? Should inventory have 
libvirt-opensuse-15.1, libvirt-opensuse-15.2, etc?

> Together with that, I really would like to have Tumbleweed supported as well.

Nod. That one is easy to name: libvirt-opensuse-tw :-).

Regards,
Jim