[libvirt] [PATCH 6/9] conf: qemu: add virtio-fs fsdriver type

Daniel P. Berrangé berrange at redhat.com
Fri Nov 22 16:54:13 UTC 2019


On Wed, Nov 20, 2019 at 09:38:15AM +0100, Ján Tomko wrote:
> On Mon, Nov 04, 2019 at 09:56:28AM +0100, Stefan Hajnoczi wrote:
> > On Fri, Nov 1, 2019 at 1:15 PM Ján Tomko <jtomko at redhat.com> wrote:
> > > 
> > > Introduce a new 'virtio-fs' driver type for filesystem.
> > > 
> > > <filesystem type='mount' accessmode='passthrough'>
> > >   <driver type='virtio-fs'/>
> > >   <source dir='/path'/>
> > >   <target dir='/path'/>
> > 
> > What happens with the target dir?
> > 
> 
> For virtio-fs, it is used the same way as with 9pfs - it is passed as
> the tag and meant as a suggestion for the guest for where to mount the
> filesystem.
> 
> For LXC, libvirt actually does the mounting so the target dir path is
> honored.
> 
> I could use some other example in the documentation that does not look
> as a path if that's too confusing. I'm not sure whether deviating
> from the existing pattern and using something like:
>  <target tag='myfs'/>
> is worth it.

Yeah, we shouldn't have called the attribute "dir", but since we have
that naming for ages now, we shouldn't change it IMHO. Just document
that its a stupid historical name :-)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list