[libvirt] [ruby PATCH] Fix default values for node_cpu_stats() and node_memory_stats()

Cole Robinson crobinso at redhat.com
Sat Nov 23 00:54:25 UTC 2019

On 11/14/19 4:57 PM, Cole Robinson wrote:
> On 10/22/19 11:47 AM, Stefano Garzarella wrote:
>> ruby_libvirt_value_to_int() returns 0 if the optional value is
>> not defined, but in node_cpu_stats() and node_memory_stats()
>> the default value of cpuNum and cellNum is -1.
> I know nothing about ruby or the libvirt bindings, but what you describe
> makes sense and matches my reading of the code. -1 is
> makes sense that would be the default.
> Reviewed-by: Cole Robinson <crobinso at redhat.com>
> CCing clalance who is the primary ruby-libvirt maintainer, but if he
> doesn't get to it by next week then I'll figure out how to build test
> it, and push

I've pushed this now

- Cole

More information about the libvir-list mailing list