[libvirt] [PATCH 1/2] Revert "network: Check for QOS before blindly using it"

Michal Privoznik mprivozn at redhat.com
Mon Nov 25 08:28:10 UTC 2019


On 11/24/19 9:12 PM, Julio Faracco wrote:
> Em sex., 22 de nov. de 2019 às 14:09, Erik Skultety
> <eskultet at redhat.com> escreveu:
>>
>> This reverts commit f4db846c32c0a1e99a0f62b340273e48f8a98ed3.
>>
>> This patch results in the following error when trying to start
>> essentially any VM with default network:
> 
> This kind of issue should be caught by test driver, shouldn't it?

Not really. The test driver doesn't call APIs of other drivers. It's 
only providing sensible outputs for APIs inputs without doing any actual 
work. An integration test would have caught this though.

Michal




More information about the libvir-list mailing list