[libvirt] [PATCH] check-symfile: Use pythonesque string formatting instead of perl

Fabiano Fidêncio fidencio at redhat.com
Tue Nov 26 08:51:18 UTC 2019


On Mon, Nov 25, 2019 at 4:41 PM Peter Krempa <pkrempa at redhat.com> wrote:
>
> Commit d30a1ad0443 translated the symbol file checker from perl to
> python by doing a literal translation in most cases. Unfortunately one
> string formatting operation was not really translated into python
> leaving users with non-helpful error:
>
> 'Symbol $1 is listed twice'
>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  scripts/check-symfile.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/check-symfile.py b/scripts/check-symfile.py
> index 0c02591991..34396b8623 100755
> --- a/scripts/check-symfile.py
> +++ b/scripts/check-symfile.py
> @@ -52,7 +52,7 @@ with open(symfile, "r") as fh:
>          line = line.strip(";")
>
>          if line in wantsyms:
> -            print("Symbol $1 is listed twice", file=sys.stderr)
> +            print("Symbol %s is listed twice" % line ,file=sys.stderr)

Nitpick, 'line ,file=...' -> 'line, file=...'





More information about the libvir-list mailing list