[libvirt] [PATCH 1/9] qemu: process: Make it obvious that virDomainDefPostParse is called with NULL opaque

Ján Tomko jtomko at redhat.com
Tue Nov 26 14:49:32 UTC 2019

On Mon, Nov 25, 2019 at 01:53:46PM +0100, Peter Krempa wrote:
>Commit c90fb5a828a added explicit use of the private copy of the qemu
>capabilities to various places. The change to qemuProcessInit was bogus
>though as at the point where we re-initiate the post parse callbacks
>priv->qemuCaps is still NULL as we clear it after shutdown of the VM and
>don't initiate it until a later point.
>Using the value from priv->qemuCaps might mislead readers of the code
>into thinking that something useful is being passed at that point so go
>with an explicit NULL instead.
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> src/qemu/qemu_process.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191126/3fbfd132/attachment-0001.sig>

More information about the libvir-list mailing list