[libvirt] [PATCH 05/10] qemu: blockjob: Log blockjobs which are dropped when untracked by qemu

Peter Krempa pkrempa at redhat.com
Tue Nov 26 15:17:29 UTC 2019


Since we don't know what happened to the job we can't do much about it
but we can at least log that this happened.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_blockjob.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 818e36435c..b83d681f06 100644
--- a/src/qemu/qemu_blockjob.c
+++ b/src/qemu/qemu_blockjob.c
@@ -501,8 +501,10 @@ qemuBlockJobRefreshJobs(virQEMUDriverPtr driver,

     /* remove data for job which qemu didn't report (the algorithm is
      * inefficient, but the possibility of such jobs is very low */
-    while ((job = virHashSearch(priv->blockjobs, qemuBlockJobRefreshJobsFindInactive, NULL, NULL)))
+    while ((job = virHashSearch(priv->blockjobs, qemuBlockJobRefreshJobsFindInactive, NULL, NULL))) {
+        VIR_WARN("dropping blockjob '%s' untracked by qemu", job->name);
         qemuBlockJobUnregister(job, vm);
+    }

     ret = 0;

-- 
2.23.0




More information about the libvir-list mailing list