[libvirt] [PATCH-for-4.2] hw/mips: Deprecate the r4k machine
aleksandar.m.mail at gmail.com
Tue Nov 26 22:03:42 UTC 2019
On Tuesday, November 26, 2019, Philippe Mathieu-Daudé <philmd at redhat.com>
> Hi Aleksandar,
> On 11/26/19 9:46 PM, Aleksandar Markovic wrote:
>> On Mon, Nov 25, 2019 at 11:41 AM Philippe Mathieu-Daudé
>> <philmd at redhat.com> wrote:
>>> The r4k machine was introduced in 2005 (6af0bf9c7) and its last
>>> logical change was in 2005 (9542611a6). After we can count 164
>>> maintenance commits (QEMU API changes) with the exception of
>>> 1 fix in 2015 (memory leak, commit 3ad9fd5a).
>>> This machine was introduced as a proof of concept to run a MIPS
>>> CPU. 2 years later, the Malta machine was add (commit 5856de80)
>>> modeling a real platform.
>>> Note also this machine has no specification except 5 lines in
>>> the header of this file:
>>> * emulates a simple machine with ISA-like bus.
>>> * ISA IO space mapped to the 0x14000000 (PHYS) and
>>> * ISA memory at the 0x10000000 (PHYS, 16Mb in size).
>>> * All peripherial devices are attached to this "bus" with
>>> * the standard PC ISA addresses.
>>> It is time to deprecate this obsolete machine. Users are
>>> recommended to use the Malta board, which hardware is well
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd at redhat.com>
>> I see you added "libvir-list" in "cc". Was it a mistake, or there was
>> some purpose?
> I don't pick the series recipient manually, I send my series with
> git-publish. Here it used the default QEMU profile.
> All profiles call git-sendmail with the cc-cmd set to the
> get_maintainer.pl script:
> $ cat .gitpublish
> # Common git-publish profiles that can be used to send patches to QEMU
> # See https://github.com/stefanha/git-publish for more information
> [gitpublishprofile "default"]
> base = master
> to = qemu-devel at nongnu.org
> cccmd = scripts/get_maintainer.pl --noroles --norolestats --nogit
> --nogit-fallback 2>/dev/null
> Having a closer look, libvir-list list was Cc'ed because it is listed as
> reviewer of the qemu-deprecated.texi file, which was modified.
> ./scripts/get_maintainer.pl -f qemu-deprecated.texi
> libvir-list at redhat.com (reviewer:Incompatible changes)
> qemu-devel at nongnu.org (open list:All patches CC here)
OK. No problem. It just looked strange.
As far as consuktations, I am just waiting for some responses within
company to establish if somebody is perhaps using this machine with some
ancient kernel. I got some opinions that are in favor of R4000 machine
deprecating, but I need to wait for all relevant departments to confirm.
What happened to TileGX?
> qemu-deprecated.texi | 5 +++++
>>> hw/mips/mips_r4k.c | 1 +
>>> MAINTAINERS | 2 +-
>>> 3 files changed, 7 insertions(+), 1 deletion(-)
>>> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
>>> index 4b4b7425ac..05265b43c8 100644
>>> --- a/qemu-deprecated.texi
>>> +++ b/qemu-deprecated.texi
>>> @@ -266,6 +266,11 @@ The 'scsi-disk' device is deprecated. Users should
>>> use 'scsi-hd' or
>>> @section System emulator machines
>>> + at subsection mips r4k platform (since 4.2)
>>> +This machine type is very old and unmaintained. Users should use the
>>> +machine type instead.
>>> @subsection pc-0.12, pc-0.13, pc-0.14 and pc-0.15 (since 4.0)
>>> These machine types are very old and likely can not be used for live
>>> diff --git a/hw/mips/mips_r4k.c b/hw/mips/mips_r4k.c
>>> index 70024235ae..0b79ad26cb 100644
>>> --- a/hw/mips/mips_r4k.c
>>> +++ b/hw/mips/mips_r4k.c
>>> @@ -294,6 +294,7 @@ void mips_r4k_init(MachineState *machine)
>>> static void mips_machine_init(MachineClass *mc)
>>> + mc->deprecation_reason = "use malta machine type instead";
>>> mc->desc = "mips r4k platform";
>>> mc->init = mips_r4k_init;
>>> mc->block_default_type = IF_IDE;
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 5e5e3e52d6..3b3a88e264 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -972,7 +972,7 @@ F: hw/net/mipsnet.c
>>> M: Aurelien Jarno <aurelien at aurel32.net>
>>> R: Aleksandar Rikalo <aleksandar.rikalo at rt-rk.com>
>>> -S: Maintained
>>> +S: Obsolete
>>> F: hw/mips/mips_r4k.c
>>> Fulong 2E
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the libvir-list