[libvirt] [PATCH 8/9] API: Introduce VIR_DOMAIN_JOB_SUCCESS field for virDomainGetJobStats

Eric Blake eblake at redhat.com
Tue Nov 26 22:54:41 UTC 2019

On 11/25/19 9:01 AM, Peter Krempa wrote:
> The statistics fields are used in two places:
> 1) virDomainGetJobStats where the job type which ultimately holds
> whether the job was successful or not is returned via a different
> argument.
> 2) The virConnectDomainEventJobCompleted event where we report just the
> statistics via typed parameters.
> Since it might be useful to report the event also for jobs which
> completed unsuccessfully and we don't have the means to transport the
> state via a different variable with the event let's add a new field
> which will hold the success state.
> Since this is meant primarily for completed jobs a plain boolean is
> sufficient to convey whether the job was successful or not.
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   include/libvirt/libvirt-domain.h | 7 +++++++
>   1 file changed, 7 insertions(+)

Reviewed-by: Eric Blake <eblake at redhat.com>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

More information about the libvir-list mailing list