[libvirt] [PATCH for 5.10] Revert "qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull"

Ján Tomko jtomko at redhat.com
Wed Nov 27 13:11:50 UTC 2019

On Wed, Nov 27, 2019 at 01:52:23PM +0100, Peter Krempa wrote:
>This reverts commit 421c9550f5446729b513ee50f5c44e6f6969b5a2.

Feel free to demote this from a sentence by removing the trailing
period, to make it easier to select.

>qemuDomainBlockPullCommon calls virDomainObjEndAPI internally so the
>original commit made us shed two references of @vm instead of one
>getting us into a premature free of @vm.
>This is not a straight revert as qemuDomainBlockPull was modified
>meanwhile. I've also added a warning comment that @vm is consumed.
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>/me hides in shame
> src/qemu/qemu_driver.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191127/c573c16c/attachment-0001.sig>

More information about the libvir-list mailing list