[libvirt] [PATCH 03/21] backup: Document new XML for backups

Peter Krempa pkrempa at redhat.com
Wed Nov 27 13:50:18 UTC 2019

On Tue, Nov 26, 2019 at 22:39:49 +0100, Peter Krempa wrote:
> From: Eric Blake <eblake at redhat.com>
> Prepare for new backup APIs by describing the XML that will represent
> a backup.  The XML resembles snapshots and checkpoints in being able
> to select actions for a set of disks, but has other differences.  It
> can support both push model (the hypervisor does the backup directly
> into the destination file) and pull model (the hypervisor exposes an
> access port for a third party to grab what is necessary).  Add
> testsuite coverage for some minimal uses of the XML.
> The <disk> element within <domainbackup> tries to model the same
> elements as a <disk> under <domain>, but sharing the RNG grammar
> proved to be hairy. That is in part because while <domain> use
> <source> to describe a host resource in use by the guest, a backup job
> is using a host resource that is not visible to the guest: a push
> backup action is instead describing a <target> (which ultimately could
> be a remote network resource, but for simplicity the RNG just
> validates a local file for now), and a pull backup action is instead
> describing a temporary local file <scratch> (which probably should not
> be a remote resource).  A future refactoring may thus introduce some
> way to parameterize RNG to accept <disk type='FOO'>...</disk> so that
> the name of the subelement can be <source> for domain, or <target> or
> <scratch> as needed for backups. Future patches may improve this area
> of code.
> Signed-off-by: Eric Blake <eblake at redhat.com>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---

Consider the following diff applied to fix 'make dist':

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 775526c358..75eee0006c 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -93,7 +93,6 @@ EXTRA_DIST = \
        domaincapsdata \
        domainbackupxml2xmlin \
        domainbackupxml2xmlout \
-       domaincapsschemadata \
        domainconfdata \
        domainschemadata \
        fchostdata \
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191127/5c4de62b/attachment-0001.sig>

More information about the libvir-list mailing list