[libvirt] [PATCH 08/21] backup: Implement virsh support for backup

Eric Blake eblake at redhat.com
Wed Nov 27 17:48:54 UTC 2019

On 11/26/19 3:39 PM, Peter Krempa wrote:
> From: Eric Blake <eblake at redhat.com>
> Introduce virsh commands for performing backup jobs.
> Signed-off-by: Eric Blake <eblake at redhat.com>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---

> +=item B<backup-begin> I<domain> [I<backupxml>]
> +[I<checkpointxml>
> +
> +Begin a new backup job. If I<backupxml> is omitted, this defaults to a full
> +backup using a push model to filenames generated by libvirt; supplying XML
> +allows fine-tuning such as requesting an incremental backup relative to an
> +earlier checkpoint, controlling which disks participate or which
> +filenames are involved, or requesting the use of a pull model backup.
> +The B<backup-dumpxml> command shows any resulting values assigned by
> +libvirt. For more information on backup XML, see:
> +L<https://libvirt.org/formatbackup.html>.
> +
> +If I<checkpointxml> is specified, a second file with a top-level
> +element of <domaincheckpoint> is used to create a simultaneous
> +checkpoint, for doing a later incremental backup relative to the time
> +the backup was created. See B<checkpoint-create> for more details on
> +checkpoints.
> +
> +This command returns as soon as possible, and the backup job runs in
> +the background; the progress of a push model backup can be checked
> +with B<domjobinfo> or by waiting for an event with B<event> (the
> +progress of a pull model backup is under the control of whatever third
> +party connects to the NBD export). The job is ended with B<domjobabort>.
> +

Does the documentation for domjobabort need any updates to cover backups?

Otherwise, your changes (well, deletions, based on dropping 
virDomainBackupEnd) to my patch make sense.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

More information about the libvir-list mailing list