[libvirt] [PATCH 10/21] qemu: domain: Introduce QEMU_ASYNC_JOB_BACKUP async job type

[Eric Blake]

On 11/26/19 3:39 PM, Peter Krempa wrote:
> We will want to use the async job infrastructure along with all the APIs
> and event for the backup job so add the backup job as a new async job
> type.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_domain.c    |  3 +++
>   src/qemu/qemu_domain.h    |  1 +
>   src/qemu/qemu_migration.c |  2 ++
>   src/qemu/qemu_process.c   | 25 +++++++++++++++++++++++++
>   4 files changed, 31 insertions(+)
> 

> @@ -210,6 +211,7 @@ qemuDomainAsyncJobPhaseToString(qemuDomainAsyncJob job,
>       case QEMU_ASYNC_JOB_SNAPSHOT:
>       case QEMU_ASYNC_JOB_START:
>       case QEMU_ASYNC_JOB_NONE:
> +    case QEMU_ASYNC_JOB_BACKUP:
>           G_GNUC_FALLTHROUGH;
>       case QEMU_ASYNC_JOB_LAST:
>           break;

Pre-existing, but looks funny to have a G_GNUC_FALLTHROUGH line with no 
other statement.  It could be deleted with no change to compiler 
behavior, or replaced by a break; I guess the only reason to keep it is 
to visually distinguish QEMU_ASYNC_JOB_LAST as different from the other 
case labels with nothing to do.

> @@ -235,6 +237,7 @@ qemuDomainAsyncJobPhaseFromString(qemuDomainAsyncJob job,
>       case QEMU_ASYNC_JOB_SNAPSHOT:
>       case QEMU_ASYNC_JOB_START:
>       case QEMU_ASYNC_JOB_NONE:
> +    case QEMU_ASYNC_JOB_BACKUP:
>           G_GNUC_FALLTHROUGH;
>       case QEMU_ASYNC_JOB_LAST:
>           break;

And again.

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org