[libvirt] [PATCH 13/21] qemu: domain: Track backup job data in the status XML

Eric Blake eblake at redhat.com
Wed Nov 27 19:05:17 UTC 2019


On 11/26/19 3:39 PM, Peter Krempa wrote:
> Store the data of a backup job along with the index counter for new
> backup jobs in the status XML. Currently we will support only one
> backup job and thus there's no necessity to add arrays of jobs.

Is this commit message slightly stale given our change to drop backup 
job id for now?

> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_domain.c | 58 ++++++++++++++++++++++++++++++++++++++++++
>   src/qemu/qemu_domain.h |  3 +++
>   2 files changed, 61 insertions(+)
> 

> +++ b/src/qemu/qemu_domain.h
> @@ -414,6 +414,9 @@ struct _qemuDomainObjPrivate {
>        * commandline for pflash drives. */
>       virStorageSourcePtr pflash0;
>       virStorageSourcePtr pflash1;
> +
> +    /* Running backup jobs. */

Should this be 'job' instead of 'jobs'?

> +    virDomainBackupDefPtr backup;
>   };
> 
>   #define QEMU_DOMAIN_PRIVATE(vm) \

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list