[libvirt] [PATCH] selinux: Drop needless getfilecon()-s

Daniel P. Berrangé berrange at redhat.com
Thu Nov 28 10:17:04 UTC 2019


On Thu, Nov 28, 2019 at 09:49:46AM +0100, Michal Privoznik wrote:
> When SELinux support was first introduced the libselinux library
> wasn't that advanced and setfilecon_raw() or fsetfilecon_raw()
> could fail even when the target context was set. Looking at the
> current code [1][2] this is no longer the case. We can drop our
> workarounds.
> 
> 1: https://github.com/SELinuxProject/selinux/blob/master/libselinux/src/setfilecon.c#L10
> 2: https://github.com/SELinuxProject/selinux/blob/master/libselinux/src/fsetfilecon.c#L10
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/security/security_selinux.c | 22 ----------------------
>  1 file changed, 22 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list