[libvirt] [PATCH 1/1] admin_server: use VIR_AUTOFREE() in adminClientGetInfo string

Daniel P. Berrangé berrange at redhat.com
Tue Oct 1 14:28:27 UTC 2019


On Tue, Oct 01, 2019 at 04:25:42PM +0200, Ján Tomko wrote:
> On Tue, Oct 01, 2019 at 03:59:07PM +0200, Erik Skultety wrote:
> > On Tue, Oct 01, 2019 at 09:12:58AM -0300, Daniel Henrique Barboza wrote:
> > > Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> > > ---
> > Reviewed-by: Erik Skultety <eskultet at redhat.com>
> > 
> > and safe for freeze
> > 
> 
> This is not a bugfix, it can wait.
> 
> Also, there is an ongoing discussion about using g_autofree once we
> start depending on gnulib, so I don't see a point in trying to convert
> code to the macro that will soon be obsolete.

After the feedback from my glib series, I'm doing a full conversion
of this file to glib's macros anyway.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list