[libvirt] [PATCH v5 00/15] CPU Model Baseline and Comparison for s390x

Collin Walling walling at linux.ibm.com
Wed Oct 2 17:32:37 UTC 2019


On 10/2/19 11:48 AM, Jiri Denemark wrote:
> On Thu, Sep 19, 2019 at 16:24:51 -0400, Collin Walling wrote:
>> Note: since I've made some changes to a lot of these patches / split
>> up some patches, I've decided to hold off on adding any r-b's in case
>> there is a specific change that someone does not agree with.
>>
>> Changelog:
>>
>>     - Properly refactored code from CPU model expansion function
>>     - Introduced a cleanup patch for CPU model expansion function
>>     - Introduced patches that modifies the refactored code to suit
>>         needs for baseline/comparison
>>     - CPU expansion function now accepts a virCPUDefPtr
>>     - Removed props parsing from CPU model comparison (they weren't
>>         used)
>>     - Cleaner error reporting when baselining/comparing with erroneous
>>         CPU models / features
>>     - Various cleanups based on feedback
> 
> Thanks. All but 15/15 are acked now and I will push them as soon as we
> leave the pre-release freeze period. The patch 15/15 needs a little bit
> of tweaking, but it is not essential and it can be pushed later as a
> follow-up patch. Alternatively, if you want to work on it while we are
> frozen, you can use the s390-cpu-apis branch (based on current master)
> of my staging repo https://gitlab.com/jirkade/libvirt.git
> 
> Jirka

Much appreciated. I'll fix 15/15 and post it as a follow-up. Thank you
for your time and offering to take on the cleanups.

> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 


-- 
Respectfully,
- Collin Walling




More information about the libvir-list mailing list