[libvirt] [jenkins-ci PATCH 09/17] Deal with ninja x ninja-build bin names

Andrea Bolognani abologna at redhat.com
Thu Oct 3 10:17:47 UTC 2019


On Tue, 2019-10-01 at 16:28 +0200, Fabiano Fidêncio wrote:
> +++ b/guests/playbooks/update/tasks/paths.yml
> +# Prefer ninja-build, fall back to ninja
> +- name: 'Export paths'
> +  set_fact:
> +    ninja: '{{ commands["ninja-build"] }}'
> +  when:
> +    - commands["ninja-build"] != ''
> +
> +- name: 'Export paths'
> +  set_fact:
> +    ninja: '{{ commands["ninja"] }}'
> +  when:
> +    - ninja is undefined

Ninja can be invoked as 'ninja' on all target platforms except for
CentOS 7, and as 'ninja-build' on all RPM-based platforms, so we
should invert this logic and prefer 'ninja' to 'ninja-build'.

With that changed,

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list