[libvirt] [PATCH 04/11] build: drop the mktempd gnulib module

Daniel P. Berrangé berrange at redhat.com
Thu Oct 3 13:53:11 UTC 2019


The mktempd module in gnulib provides an equivalent to 'mktemp -d' on
platforms which lack this shell command. All platforms on which libvirt
runs the affected tests have 'mktemp -d' support, so the gnulib module
is not required.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 bootstrap.conf    | 1 -
 tests/test-lib.sh | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/bootstrap.conf b/bootstrap.conf
index 1fa0a38389..9964231bb7 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -71,7 +71,6 @@ mgetgroups
 mkdtemp
 mkostemp
 mkostemps
-mktempd
 net_if
 netdb
 nonblocking
diff --git a/tests/test-lib.sh b/tests/test-lib.sh
index ef5a47b565..c19005a371 100644
--- a/tests/test-lib.sh
+++ b/tests/test-lib.sh
@@ -256,8 +256,7 @@ fi
 # a partition, or to undo any other global state changes.
 cleanup_() { :; }
 
-mktempd="$abs_top_srcdir/build-aux/mktempd"
-t_=$("$SHELL" "$mktempd" "$test_dir_" lv-$this_test.XXXXXXXXXX) \
+t_=$("mktemp" "-d" "$test_dir_/lv-$this_test.XXXXXXXXXX") \
     || error_ "failed to create temporary directory in $test_dir_"
 
 # Run each test from within a temporary sub-directory named after the
-- 
2.21.0




More information about the libvir-list mailing list