[libvirt] [PATCH 03/10] python: fix use of undeclared variables in python scripts

Daniel P. Berrangé berrange at redhat.com
Wed Oct 9 12:58:37 UTC 2019


docs/apibuild.py:2436:65: F821 undefined name 'first_letter'
                        chunks.append(["chunk%s" % (chunk - 1), first_letter, letter])
                                                                ^
src/hyperv/hyperv_wmi_generator.py:415:57: F821 undefined name 'number'
        report_error("line %d: invalid block header" % (number))
                                                        ^

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 build-aux/syntax-check.mk          | 2 --
 docs/apibuild.py                   | 1 +
 src/hyperv/hyperv_wmi_generator.py | 4 ++--
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 1ad0c626e1..97255908b8 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -884,7 +884,6 @@ FLAKE8_WHITESPACE = E211,E221,E222,E225,E226,E231,E261
 FLAKE8_BLANK_LINES = E301,E302,E303,E305
 FLAKE8_LINE_LENGTH = E501
 FLAKE8_STATEMENTS = E722,E741
-FLAKE8_ERRORS = F821
 FLAKE8_WARNINGS = W504,W605
 
 FLAKE8_IGNORE = $(FLAKE8_INDENTATION),$\
@@ -892,7 +891,6 @@ FLAKE8_IGNORE = $(FLAKE8_INDENTATION),$\
 		$(FLAKE8_BLANK_LINES),$\
 		$(FLAKE8_LINE_LENGTH),$\
 		$(FLAKE8_STATEMENTS),$\
-		$(FLAKE8_ERRORS),$\
 		$(FLAKE8_WARNINGS) \
 		$(NULL)
 
diff --git a/docs/apibuild.py b/docs/apibuild.py
index 3f0b72d18e..dc52caf76d 100755
--- a/docs/apibuild.py
+++ b/docs/apibuild.py
@@ -2401,6 +2401,7 @@ class docBuilder:
         count = 0
         chunk = 0
         chunks = []
+        first_letter = None
         for id in typ:
             if len(index[id]) > 30:
                 continue
diff --git a/src/hyperv/hyperv_wmi_generator.py b/src/hyperv/hyperv_wmi_generator.py
index a9ece0ff00..4f486913bd 100755
--- a/src/hyperv/hyperv_wmi_generator.py
+++ b/src/hyperv/hyperv_wmi_generator.py
@@ -407,7 +407,7 @@ def report_error(message):
 
 
 
-def parse_class(block):
+def parse_class(block, number):
     # expected format: class <name>
     header_items = block[0][1].split()
 
@@ -489,7 +489,7 @@ def main():
         if block is not None:
             if line == "end":
                 if block[0][1].startswith("class"):
-                    parse_class(block)
+                    parse_class(block, number)
 
                 block = None
             else:
-- 
2.21.0




More information about the libvir-list mailing list