[libvirt] [PATCH] conf: remove parse code for long-extinct "<state devaddr='d:b:s'/>

[Ján Tomko]

Unmatched double quote in the commit summary

On Wed, Oct 09, 2019 at 12:39:15PM -0400, Laine Stump wrote:
>Back in July 2009, in the days before libvirt supported explicitly
>assigning a PCI address to every device, code was added to save the
>PCI addresses of hotplugged network, disk, and hostdevs in the domain
>status with this XML element:
>
>   <status devaddr='domain:bus:slot'/>

s/status/state/

>
>This was added in commits 4e21a95a, 01654107, in v0.7.0, and 0c5b7b93
>in v0.7.1.
>
>Then just a few months later, in November 2009, The code that actually
>formatted the "devaddr='blah' into the status XML was removed by

Mismatched double quote

>commit 1b0cce7d3 (which "Introduce[d] a standardized data structure for
>device addresses"). The code to *parse* the devaddr from the status
>was left in for backward compatibility though (it just parses it into
>the "standard" PCI address).
>
>At the time the devaddr attribute was added, a few other attributes
>already existed in the <status> element for network devices, and these
>were removed over time (I haven't checked the exact dates of this),
>but 10 years later, in libvirt v5.8.0, we *still* maintain code to
>parse <status devaddr='blah'/> from the domain status.
>

s/status/state/

>In the meantime, even distros so old that we no longer support them in
>upstream libvirt are using a libvirt new enough that it doesn't ever
>write <status devaddr='blah'/> to the domain status XML.

s/status/state/

>
>Since the only way a current libvirt would ever encounter this element
>would be if someone was upgrading directly from libvirt <=v0.7.5 with

Please put a space between <= and v0.7.5

>running guests, it seems safe to finally remove the code that parses it.
>
>Signed-off-by: Laine Stump <laine at redhat.com>
>---
>
>The git commit ID's etc are probably not essential to have in the log
>message, but I did think it was interesting that we've been carrying
>this for so many years...

Having the commit ID's there shows that you actually looked at the
history instead of just digging in your memory.

>
>
> src/conf/domain_conf.c | 76 +++++-------------------------------------
> 1 file changed, 8 insertions(+), 68 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191009/23803ffe/attachment-0001.sig>