[libvirt] [PATCH] libvirt_python:fix bug of sanitytest.py script

Cole Robinson crobinso at redhat.com
Wed Oct 9 19:19:00 UTC 2019


On 9/10/19 2:19 AM, ossdev at puresoftware.com wrote:
> From: ossdev <ossdev at puresoftware.com>
> 
> libvirt-python:fix bug of sanitytest.py script
> 

Hmm, what exactly is the bug you are hitting? Are you seeing an error? I 
don't exactly follow what the patch is achieving

> Signed-off-by: ossdev <ossdev at puresoftware.com>

This needs to list your real name, more info at #6 in this section:
https://libvirt.org/hacking.html#patches

- Cole

> ---
>   sanitytest.py | 19 +++++++++++++++++--
>   1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/sanitytest.py b/sanitytest.py
> index e87b57d..c5d1f42 100644
> --- a/sanitytest.py
> +++ b/sanitytest.py
> @@ -22,6 +22,21 @@ def get_libvirt_api_xml_path():
>           sys.exit(proc.returncode)
>       return stdout.splitlines()[0]
>   
> +def sanitize_enum_val(value):
> +    if value == 'VIR_TYPED_PARAM_INT':
> +        value = 1
> +    elif value == 'VIR_TYPED_PARAM_UINT':
> +        value = 2
> +    elif value == 'VIR_TYPED_PARAM_LLONG':
> +        value = 3
> +    elif value == 'VIR_TYPED_PARAM_ULLONG':
> +        value = 4
> +    elif value == 'VIR_TYPED_PARAM_DOUBLE':
> +        value = 5
> +    elif value == 'VIR_TYPED_PARAM_BOOLEAN':
> +        value = 6
> +    return value
> +
>   # Path to the libvirt API XML file
>   if len(sys.argv) >= 3:
>       xml = sys.argv[2]
> @@ -48,8 +63,8 @@ set = tree.xpath('/api/symbols/enum')
>   for n in set:
>       typ = n.attrib['type']
>       name = n.attrib['name']
> -    val = n.attrib['value']
> -
> +    #val = n.attrib['value']
> +    val = sanitize_enum_val(n.attrib['value'])
>       if typ not in enumvals:
>           enumvals[typ] = {}
>   
>




More information about the libvir-list mailing list