[libvirt] [PATCH v2 1/1] IDE: deprecate ide-drive

[Philippe Mathieu-Daudé]

On 10/10/19 1:26 PM, Peter Krempa wrote:
> On Thu, Oct 10, 2019 at 13:22:37 +0200, Philippe Mathieu-Daudé wrote:
>> On 10/10/19 12:43 AM, John Snow wrote:
>>> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
>>> I'd like to refactor these some day, and getting rid of the super-object
>>> will make that easier.
>>>
>>> Either way, we don't need this.
>>>
>>> Libvirt-checked-by: Peter Krempa <pkrempa at redhat.com>
>>
>> Peter made a comment regarding Laszlo's Regression-tested-by tag:
>>
>>    [...] nobody else is using
>>    this convention (there are exactly 0 instances of
>>    "Regression-tested-by" in the project git log as far as
>>    I can see), and so in practice people reading the commits
>>    won't really know what you meant by it. Everybody else
>>    on the project uses "Tested-by" to mean either of the
>>    two cases you describe above, without distinction...
>>
>> It probably applies to 'Libvirt-checked-by' too.
> 
> I certainly didn't test it. So feel free to drop that line altogether.

But you reviewed it, can we use your 'Reviewed-by' instead?