[libvirt] [PATCH v3 18/19] util: replace strerror/strerror_r with g_strerror
Ján Tomko
jtomko at redhat.com
Thu Oct 10 12:48:17 UTC 2019
On Thu, Oct 10, 2019 at 11:54:12AM +0100, Daniel P. Berrangé wrote:
>g_strerror is offers the safety/correctness benefits of strerror_r, with
>the API design convenience of strerror.
>
>Use of virStrerror should be eliminated through the codebase in favour
>of g_strerror.
>
>commandhelper.c is a special case as its a tiny single threaded test
>program, not linked to glib, so it just uses traditional strerror().
>
>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> bootstrap.conf | 2 --
> docs/hacking.html.in | 4 ++++
> src/util/virerror.c | 9 +++++----
> src/util/virerror.h | 1 +
> tests/commandtest.c | 10 +++++-----
> tests/qemumonitortestutils.c | 2 +-
> tests/seclabeltest.c | 4 ++--
> tests/testutils.c | 6 +++---
> tests/virhostcputest.c | 4 ++--
> tests/virtestmock.c | 4 ++--
> 10 files changed, 25 insertions(+), 21 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko at redhat.com>
Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191010/4b83d594/attachment-0001.sig>
More information about the libvir-list
mailing list