[libvirt] [PATCH 00/10] Clean up error preservation/restoration
Michal Privoznik
mprivozn at redhat.com
Wed Oct 16 13:31:36 UTC 2019
On 10/15/19 7:37 PM, John Ferlan wrote:
> I was going through some old git trees and found this one started before
> I 'altered' my Red Hat career path. Seeing as no one has picked it up from
> https://wiki.libvirt.org/page/BiteSizedTasks - figured I may as well post
> it rather than throw it away ;-)
>
> The change essentially alters virSaveLastError ... virSetError and
> virFreeError paths to use virErrorPreserveLast & virErrorRestore.
>
>
> John Ferlan (10):
> conf: Use consistent error preservation and restoration calls
> src: Use consistent error preservation and restoration calls
> libxl: Use consistent error preservation and restoration calls
> lxc: Use consistent error preservation and restoration calls
> qemu: Use consistent error preservation and restoration calls
> remote: Use consistent error preservation and restoration calls
> storage: Use consistent error preservation and restoration calls
> util: Use consistent error preservation and restoration calls
> vz: Use consistent error preservation and restoration calls
> tools: Use consistent error preservation and restoration calls
>
> src/conf/domain_conf.c | 7 +--
> src/libvirt-stream.c | 36 +++++-------
> src/libxl/libxl_migration.c | 18 ++----
> src/lxc/lxc_driver.c | 9 ++-
> src/lxc/lxc_process.c | 7 +--
> src/qemu/qemu_cgroup.c | 14 ++---
> src/qemu/qemu_command.c | 12 ++--
> src/qemu/qemu_domain.c | 7 +--
> src/qemu/qemu_driver.c | 36 +++++-------
> src/qemu/qemu_migration.c | 85 +++++++++------------------
> src/qemu/qemu_migration_params.c | 9 ++-
> src/qemu/qemu_monitor.c | 19 +++---
> src/qemu/qemu_process.c | 7 +--
> src/remote/remote_daemon_stream.c | 17 +++---
> src/storage/storage_backend_disk.c | 5 +-
> src/storage/storage_backend_logical.c | 5 +-
> src/storage/storage_driver.c | 8 +--
> src/util/vircgroup.c | 18 +++---
> src/util/virfirewall.c | 6 +-
> src/vz/vz_driver.c | 9 +--
> tools/virsh.c | 7 +--
> tools/virt-admin.c | 7 +--
> 22 files changed, 137 insertions(+), 211 deletions(-)
>
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
Michal
More information about the libvir-list
mailing list