[libvirt] [PATCH v4 0/2] Add resolution properties for QEMU video devices

[Julio Faracco]

I usually don't bother list with ordinary messages, but...
Thank you very much for your guidance and patience, Cole!
I appreciate it!

Em qui, 17 de out de 2019 às 17:25, Cole Robinson
<crobinso at redhat.com> escreveu:
>
> On 10/17/19 12:30 AM, jcfaracco at gmail.com wrote:
> > From: Julio Faracco <jcfaracco at gmail.com>
> >
> > This serie adds resolution ('x' and 'y') properties into XML definition
> > for QEMU video devices to specify a default resolution. This specific
> > case is not considering those attributes as a QEMU capabilities due to
> > complexity of code versus test complexity versus a real gain. This
> > skeleton would work very well initially. After, it should be possible to
> > include them as a capabilities without changing this serie.
> >
> > v1-v2: Adds suggestions of multiple members.
> > v2-v3: Adds Cole's suggestions.
> > v3-v4: Adds Cole's suggestions again.
> >
>
> Reviewed-by: Cole Robinson <crobinso at redhat.com>
>
> and pushed. Thanks for your patience!
>
> - Cole
>
> > Julio Faracco (2):
> >   conf: Add 'x' and 'y' resolution into video XML definition
> >   qemu: Generate 'xres' and 'yres' for QEMU video devices
> >
> >  docs/formatdomain.html.in                     |  5 +-
> >  docs/schemas/domaincommon.rng                 | 10 +++
> >  src/conf/domain_conf.c                        | 63 ++++++++++++++++++-
> >  src/conf/domain_conf.h                        |  5 ++
> >  src/conf/virconftypes.h                       |  3 +
> >  src/qemu/qemu_command.c                       |  5 ++
> >  src/qemu/qemu_domain.c                        | 11 ++++
> >  .../video-qxl-resolution.args                 | 32 ++++++++++
> >  .../qemuxml2argvdata/video-qxl-resolution.xml | 42 +++++++++++++
> >  tests/qemuxml2argvtest.c                      |  4 ++
> >  .../video-qxl-resolution.xml                  | 42 +++++++++++++
> >  tests/qemuxml2xmltest.c                       |  1 +
> >  12 files changed, 221 insertions(+), 2 deletions(-)
> >  create mode 100644 tests/qemuxml2argvdata/video-qxl-resolution.args
> >  create mode 100644 tests/qemuxml2argvdata/video-qxl-resolution.xml
> >  create mode 100644 tests/qemuxml2xmloutdata/video-qxl-resolution.xml
> >
>
>
> - Cole