[libvirt] [PATCH RFC 08/40] conf: Remove virDomainDiskPathByName
Daniel Henrique Barboza
danielhb413 at gmail.com
Fri Oct 18 19:13:49 UTC 2019
On 10/18/19 1:10 PM, Peter Krempa wrote:
> Last use was removed in 29682196d8f.
>
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> src/conf/domain_conf.c | 11 -----------
> src/conf/domain_conf.h | 1 -
> src/libvirt_private.syms | 1 -
> 3 files changed, 13 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 88e93f6fb8..8b4e80fa8d 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -16922,17 +16922,6 @@ virDomainDiskIndexByName(virDomainDefPtr def, const char *name,
> return candidate;
> }
>
> -/* Return the path to a disk image if a string identifies at least one
> - * disk belonging to the domain (both device strings 'vda' and paths
> - * '/path/to/file' are converted into '/path/to/file'). */
> -const char *
> -virDomainDiskPathByName(virDomainDefPtr def, const char *name)
> -{
> - int idx = virDomainDiskIndexByName(def, name, true);
> -
> - return idx < 0 ? NULL : virDomainDiskGetSource(def->disks[idx]);
> -}
> -
> virDomainDiskDefPtr
> virDomainDiskByName(virDomainDefPtr def,
> const char *name,
> diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
> index b33e5334f4..ad8e88c2ee 100644
> --- a/src/conf/domain_conf.h
> +++ b/src/conf/domain_conf.h
> @@ -3162,7 +3162,6 @@ int virDomainDiskIndexByName(virDomainDefPtr def, const char *name,
> virDomainDiskDefPtr virDomainDiskByName(virDomainDefPtr def,
> const char *name,
> bool allow_ambiguous);
> -const char *virDomainDiskPathByName(virDomainDefPtr, const char *name);
> int virDomainDiskInsert(virDomainDefPtr def,
> virDomainDiskDefPtr disk)
> G_GNUC_WARN_UNUSED_RESULT;
> diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> index 588f0a4356..e6d40d1cbe 100644
> --- a/src/libvirt_private.syms
> +++ b/src/libvirt_private.syms
> @@ -362,7 +362,6 @@ virDomainDiskMirrorStateTypeFromString;
> virDomainDiskMirrorStateTypeToString;
> virDomainDiskModelTypeFromString;
> virDomainDiskModelTypeToString;
> -virDomainDiskPathByName;
> virDomainDiskRemove;
> virDomainDiskRemoveByName;
> virDomainDiskSetBlockIOTune;
>
More information about the libvir-list
mailing list