[libvirt] [PATCH RFC 14/40] qemu: block: Don't query monitor in qemuBlockStorageSourceCreateDetectSize

Eric Blake eblake at redhat.com
Fri Oct 18 20:59:45 UTC 2019


On 10/18/19 11:10 AM, Peter Krempa wrote:
> Calling the monitor was convenient for the implementation in
> qemuDomainBlockCopyCommon, but causes the snapshot code to call
> query-named-block-nodes for every disk.
> 
> Fix this by removing the monitor call from
> qemuBlockStorageSourceCreateDetectSize so that the data can be reused in
> loops.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_block.c  | 26 +++++---------------------
>   src/qemu/qemu_block.h  |  5 ++---
>   src/qemu/qemu_driver.c | 33 ++++++++++++++++++++++++++++-----
>   3 files changed, 35 insertions(+), 29 deletions(-)
> 

Nice reduction in monitor calls for guests with lots of disks.

ACK

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list