[libvirt] [PATCH 12/16] docs: hacking: remove reference to ATTRIBUTE_FORMAT

Ján Tomko jtomko at redhat.com
Fri Oct 18 22:36:46 UTC 2019


Prefer G_GNUC_PRINTF.

Also, pick another example than virAsprintf since it may get
removed in the future.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 docs/hacking.html.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/hacking.html.in b/docs/hacking.html.in
index 384da96d60..8c68cd1c3c 100644
--- a/docs/hacking.html.in
+++ b/docs/hacking.html.in
@@ -1378,12 +1378,12 @@ BAD:
       Whenever you add a new printf-style function, i.e., one with a format
       string argument and following "..." in its prototype, be sure to use
       gcc's printf attribute directive in the prototype.  For example, here's
-      the one for virAsprintf, in util.h:
+      the one for virCommandAddEnvFormat in vircommand.h:
     </p>
 
 <pre>
-  int virAsprintf(char **strp, const char *fmt, ...)
-      ATTRIBUTE_FORMAT(printf, 2, 3);
+  void virCommandAddEnvFormat(virCommandPtr cmd, const char *format, ...)
+      G_GNUC_PRINTF(2, 3);
 </pre>
 
     <p>
-- 
2.21.0




More information about the libvir-list mailing list