[libvirt] [PATCH 00/10] tools: remove vshStrdup (glib chronicles)

[Daniel Henrique Barboza]

On 10/18/19 7:37 PM, Ján Tomko wrote:
> Ján Tomko (10):
>    tools: cmdDomblkinfoGet: reindent parameters
>    virsh: use g_strdup in cmdDomblkinfoGet
>    virsh: use g_strdup in virshDomainGetEditMetadata
>    virsh: getSignalNumber: rename variables
>    virsh: getSignalNumber: use g_autofree
>    virsh: getSignalNumber: use g_strdup
>    tools: vshCommandArgvGetArg: one parameter per line
>    tools: vshCommandArgvGetArg: prefer g_strdup
>    tools: prefer g_strdup to vshStrdup
>    tools: delete vshStrdup


All patches:

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>


Question: I see that you're pushing the glib chronicles recently. Do you 
have plans to do the virAsprintf -> g_strdup_printf conversion?

I am asking because I started this conversion yesterday, and the amount 
of calls to be converted is so massive that it's kind of funny. And it's 
not a work that I'll be able to full commit during the workday. So, if 
this conversion is under your radar and you want to get it done ASAP 
(meaning that you'll get it done faster than I'm capable of), let me 
know and I'll stand down from pursuing that.


Thanks,


DHB


> 
>   tools/virsh-checkpoint.c     |  4 +--
>   tools/virsh-domain-monitor.c | 27 ++++++++++----------
>   tools/virsh-domain.c         | 38 ++++++++++++----------------
>   tools/virsh-nodedev.c        |  5 ++--
>   tools/virsh-pool.c           | 30 +++++++++++-----------
>   tools/virsh-snapshot.c       |  6 ++---
>   tools/virsh-volume.c         | 11 ++++-----
>   tools/virsh.c                |  9 +++----
>   tools/virt-admin.c           |  6 ++---
>   tools/vsh.c                  | 48 ++++++++++++++----------------------
>   tools/vsh.h                  |  4 ---
>   11 files changed, 81 insertions(+), 107 deletions(-)
>