[libvirt] [PATCH] conf: remove NULL check from virDomainQemuMonitorEventNew

Ján Tomko jtomko at redhat.com
Tue Oct 22 13:59:53 UTC 2019


The qemu_domain_monitor_event_msg struct in qemu_protocol.x
defines event as a nonnull_string and qemuMonitorJSONIOProcessEvent
also errors out on a non-NULL event.

Drop the check to fix the build with static analysis.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 src/conf/domain_event.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
index 644f6eb595..33fbf10406 100644
--- a/src/conf/domain_event.c
+++ b/src/conf/domain_event.c
@@ -1934,20 +1934,12 @@ virDomainQemuMonitorEventNew(int id,
                                  0, id, name, uuid, uuidstr)))
         return NULL;
 
-    /* event is mandatory, details are optional */
-    if (!event)
-        goto error;
-
     ev->event = g_strdup(event);
     ev->seconds = seconds;
     ev->micros = micros;
     ev->details = g_strdup(details);
 
     return (virObjectEventPtr)ev;
-
- error:
-    virObjectUnref(ev);
-    return NULL;
 }
 
 
-- 
2.19.2




More information about the libvir-list mailing list