[libvirt] [PATCH RFC 17/40] conf: snapshot: Don't clear current snapshot when redefining an existing one

[Ján Tomko]

On Fri, Oct 18, 2019 at 06:11:02PM +0200, Peter Krempa wrote:
>There's no point in clearing the current snapshot when we are just
>changing the definition of the current snapshot as by the virtue of the
>'update_current' flag the same snapshot would become current in
>qemuDomainSnapshotCreateXML.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/snapshot_conf.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
>index 0e9d307321..ec47e14955 100644
>--- a/src/conf/snapshot_conf.c
>+++ b/src/conf/snapshot_conf.c
>@@ -989,7 +989,7 @@ virDomainSnapshotRedefinePrep(virDomainObjPtr vm,
>                               virDomainSnapshotDefPtr *defptr,
>                               virDomainMomentObjPtr *snap,
>                               virDomainXMLOptionPtr xmlopt,
>-                              bool *update_current,
>+                              bool *update_current G_GNUC_UNUSED,
>                               unsigned int flags)
> {
>     virDomainSnapshotDefPtr def = *defptr;

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191024/8f6e0444/attachment-0001.sig>