[libvirt] [libvirt-dbus][PATCH v3 1/2] Introduce Domain Snapshot Interface

[Pavel Hrdina]

On Wed, Oct 23, 2019 at 01:11:45PM +0200, Simon Kobyda wrote:
> Signed-off-by: Simon Kobyda <skobyda at redhat.com>
> ---
>  data/org.libvirt.DomainSnapshot.xml |  7 +++
>  src/connect.c                       |  6 +++
>  src/connect.h                       |  1 +
>  src/domainsnapshot.c                | 75 +++++++++++++++++++++++++++++
>  src/domainsnapshot.h                |  9 ++++
>  src/meson.build                     |  1 +
>  src/util.c                          | 53 ++++++++++++++++++++
>  src/util.h                          | 16 ++++++
>  8 files changed, 168 insertions(+)
>  create mode 100644 data/org.libvirt.DomainSnapshot.xml
>  create mode 100644 src/domainsnapshot.c
>  create mode 100644 src/domainsnapshot.h
> 
> diff --git a/data/org.libvirt.DomainSnapshot.xml b/data/org.libvirt.DomainSnapshot.xml
> new file mode 100644
> index 0000000..8ba059f
> --- /dev/null
> +++ b/data/org.libvirt.DomainSnapshot.xml

I've missed this in the previous review, you need to list the XML in
data/meson.build file to have it properly installed.

Otherwise looks good.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191024/a8f381d7/attachment-0001.sig>