[libvirt] [PATCH 01/19] util: buffer: Simplify convoluted condition

Peter Krempa pkrempa at redhat.com
Thu Oct 24 13:56:19 UTC 2019


Spare a few more lines rather than having a condition with a nested
ternary.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/util/virbuffer.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c
index 04c8fd7291..a58481430a 100644
--- a/src/util/virbuffer.c
+++ b/src/util/virbuffer.c
@@ -64,11 +64,19 @@ virBufferAdjustIndent(virBufferPtr buf, int indent)
 {
     if (!buf || buf->error)
         return;
-    if (indent > 0 ? INT_MAX - indent < buf->indent
-        : buf->indent < -indent) {
-        virBufferSetError(buf, -1);
-        return;
+
+    if (indent > 0) {
+        if (INT_MAX - indent < buf->indent) {
+            virBufferSetError(buf, -1);
+            return;
+        }
+    } else {
+        if (buf->indent < -indent) {
+            virBufferSetError(buf, -1);
+            return;
+        }
     }
+
     buf->indent += indent;
 }

-- 
2.21.0




More information about the libvir-list mailing list