[libvirt] [PATCH 02/11] build: drop the getopt-posix gnulib module

Ján Tomko jtomko at redhat.com
Thu Oct 3 15:12:52 UTC 2019


On Thu, Oct 03, 2019 at 02:53:09PM +0100, Daniel P. Berrangé wrote:
>The getopt-posix module fixes a problem with optind being incorrectly
>set after a failed option parse. This is not something that matters to
>libvirt code.
>

This module was introduced by:

commit b436a8ae5ccb04f8cf893d882d52ab5efc713307
    gnulib: add getopt module

for the patches implementing command line parsing for the bhyve
driver. So you can also remove the gl_REPLACE_GETOPT_ALWAYS definition
in m4/virt-driver-bhyve.m4 and delete gnulib/lib/getopt.c from
POTFILES.in.

>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> bootstrap.conf | 1 -
> po/POTFILES    | 1 -
> 2 files changed, 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191003/bd532bd3/attachment-0001.sig>


More information about the libvir-list mailing list