[libvirt] [PATCH 02/11] build: drop the getopt-posix gnulib module

Daniel P. Berrangé berrange at redhat.com
Thu Oct 3 15:40:17 UTC 2019


On Thu, Oct 03, 2019 at 05:12:52PM +0200, Ján Tomko wrote:
> On Thu, Oct 03, 2019 at 02:53:09PM +0100, Daniel P. Berrangé wrote:
> > The getopt-posix module fixes a problem with optind being incorrectly
> > set after a failed option parse. This is not something that matters to
> > libvirt code.
> > 
> 
> This module was introduced by:
> 
> commit b436a8ae5ccb04f8cf893d882d52ab5efc713307
>    gnulib: add getopt module
> 
> for the patches implementing command line parsing for the bhyve
> driver. So you can also remove the gl_REPLACE_GETOPT_ALWAYS definition
> in m4/virt-driver-bhyve.m4 and delete gnulib/lib/getopt.c from
> POTFILES.in.

POTFILES.in was renamed to POTFILES which I've updated here.

> 
> > Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> > ---
> > bootstrap.conf | 1 -
> > po/POTFILES    | 1 -
> > 2 files changed, 2 deletions(-)
> > 
> 
> Reviewed-by: Ján Tomko <jtomko at redhat.com>
> 
> Jano



Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list