[libvirt] [PATCH] build: stop clang complaining about redefined typedefs

[Fabiano Fidêncio]

On Tue, Oct 8, 2019 at 5:14 PM Daniel P. Berrangé <berrange at redhat.com> wrote:
>
> Clang's gnu99 mode is not quite the same as GCC's. It will complain
> about redefined typedefs being a C11 feature, while GCC does not
> complain and allows them in GNU99.
>
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>
> Technically a build breaker fix, but given my track record of
> breaking the build today/yestday, lets have a reviewer approve :-)
>
>  m4/virt-compile-warnings.m4 | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4
> index 26f231f97e..4f9eee121c 100644
> --- a/m4/virt-compile-warnings.m4
> +++ b/m4/virt-compile-warnings.m4
> @@ -125,6 +125,10 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
>      # We do "bad" function casts all the time for event callbacks
>      wantwarn="$wantwarn -Wno-cast-function-type"
>
> +    # CLang incorrectly complains about dup typedefs win gnu99 mode
> +    # so use this CLang-specific arg to keep it quiet
> +    wantwarn="$wantwarn -Wno-typedef-redefinition"
> +

Is this the *only* failure we have with CLang? If so ...
Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

Best Regards,
-- 
Fabiano Fidêncio