[libvirt] [PATCH 02/10] build: change flake8 to use blacklist instead of whitelist

Eric Blake eblake at redhat.com
Wed Oct 9 13:33:10 UTC 2019


On 10/9/19 7:58 AM, Daniel P. Berrangé wrote:
> The current flake8 check only looks at one item (semicolons at end of
> line). This means that our code quality will continue to get worse,
> violating an increasing number of checks.
> 
> Switching to a whitelist means that we freeze the badness at its
> current level & can incrementally fix things up.
> 
> We are excluding the folllowing...

following

> 
> Indentation:
> 

> Warnings:
> 
>    W504 line break after binary operator
>    W605 invalid escape sequence ‘x’

Might also be worth a mention that later patches will fix up some 
culprits and re-enable those checks.

> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>   build-aux/syntax-check.mk | 21 +++++++++++++++++++--
>   1 file changed, 19 insertions(+), 2 deletions(-)
-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list