[libvirt] [PATCH v3 19/19] build: remove use of usleep gnulib module in favour of g_usleep

Ján Tomko jtomko at redhat.com
Thu Oct 10 12:48:52 UTC 2019


On Thu, Oct 10, 2019 at 11:54:13AM +0100, Daniel P. Berrangé wrote:
>The usleep function was missing on older mingw versions, but we can rely
>on it existing everywhere these days. It may only support times upto 1
>second in duration though, so we'll prefer to use g_usleep instead.
>
>The commandhelper program is not changed since that can't link to glib.
>Fortunately it doesn't need to build on Windows platforms either.
>
>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> bootstrap.conf                      | 1 -
> src/hyperv/hyperv_driver.c          | 2 +-
> src/hyperv/hyperv_wmi.c             | 4 ++--
> src/locking/lock_daemon.c           | 2 +-
> src/locking/lock_driver_sanlock.c   | 2 +-
> src/lxc/lxc_controller.c            | 2 +-
> src/lxc/lxc_driver.c                | 2 +-
> src/lxc/lxc_process.c               | 2 +-
> src/network/bridge_driver.c         | 2 +-
> src/nwfilter/nwfilter_dhcpsnoop.c   | 4 ++--
> src/nwfilter/nwfilter_learnipaddr.c | 2 +-
> src/qemu/qemu_monitor_json.c        | 2 +-
> src/qemu/qemu_process.c             | 2 +-
> src/qemu/qemu_tpm.c                 | 2 +-
> src/rpc/virnetsocket.c              | 2 +-
> src/security/security_manager.c     | 2 +-
> src/storage/storage_util.c          | 4 ++--
> src/util/vircgroup.c                | 2 +-
> src/util/virfile.c                  | 2 +-
> src/util/virnetdev.c                | 2 +-
> src/util/virnetdevip.c              | 2 +-
> src/util/virnetdevmacvlan.c         | 2 +-
> src/util/virnetdevvportprofile.c    | 2 +-
> src/util/virpci.c                   | 8 ++++----
> src/util/virprocess.c               | 4 ++--
> src/util/virtime.c                  | 2 +-
> src/vbox/vbox_common.c              | 2 +-
> tests/commandtest.c                 | 6 +++---
> tests/eventtest.c                   | 4 ++--
> tests/fdstreamtest.c                | 4 ++--
> tools/virsh-domain.c                | 2 +-
> 31 files changed, 41 insertions(+), 42 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191010/6745c4b0/attachment-0001.sig>


More information about the libvir-list mailing list