[libvirt] [PATCH v2 2/3] tests: libxl: ACPI slic table test

[Jim Fehlig]

On 9/16/19 6:47 AM, Marek Marczykowski-Górecki wrote:
> On Mon, Sep 16, 2019 at 12:23:35PM +0000, Jim Fehlig wrote:
>> On 9/15/19 1:43 PM, Marek Marczykowski-Górecki  wrote:
>>> Signed-off-by: Marek Marczykowski-Górecki <marmarek at invisiblethingslab.com>
>>> ---
>>>    tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json | 54 +++++++++++++-
>>>    tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml  | 32 ++++++++-
>>>    tests/libxlxml2domconfigtest.c                       |  2 +-
>>>    3 files changed, 88 insertions(+)
>>>    create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
>>>    create mode 100644 tests/libxlxml2domconfigdata/fullvirt-acpi-slic.xml
>>>
>>> diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
>>> new file mode 100644
>>> index 0000000..5d85d75
>>> --- /dev/null
>>> +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json
>>> @@ -0,0 +1,54 @@
>>> +{
>>> +    "c_info": {
>>> +        "type": "hvm",
>>> +        "name": "XenGuest2",
>>> +        "uuid": "c7a5fdb2-cdaf-9455-926a-d65c16db1809"
>>> +    },
>>> +    "b_info": {
>>> +        "max_vcpus": 1,
>>> +        "avail_vcpus": [
>>> +            0
>>> +        ],
>>> +        "max_memkb": 592896,
>>> +        "target_memkb": 403456,
>>> +        "shadow_memkb": 5656,
>>> +        "sched_params": {
>>> +        },
>>> +        "nested_hvm": "False",
>>
>> I had to remove the above line otherwise 'make check' fails. Did it work for you
>> as is?
> 
> Yes, it works for me. But what's interesting, if I remove it, it works
> too. Other modifications do cause the test to fail, so the test was
> called. Maybe it's about Xen libs version? 4.8 here.

I think so. Starting with Xen 4.10 'nested_hvm' is not included in json config 
if it is set to the default value (which is consistent with other settings). 
I've removed it in my local branch and will push the series soon.

BTW, the mentioning of versions got me to thinking that we should bump the 
minimum supported Xen version to 4.9. According to the support matrix for older 
xen versions [0], 4.8 general support ended June 2018 and security support ends 
in Dec 2019 (soon). 4.9 general support ends in Jan 2020 and security support 
extends until July 2020. What is your opinion on bumping the minimum version to 4.9?

Regards,
Jim

[0] https://wiki.xenproject.org/wiki/Xen_Project_Release_Features