[libvirt] [PATCH 0/2] conf: Fix up empty 'network' cdroms
Michal Privoznik
mprivozn at redhat.com
Tue Oct 15 14:09:19 UTC 2019
On 10/15/19 3:35 PM, Peter Krempa wrote:
> Peter Krempa (2):
> conf: Reset disk type if <source> element is completely missing
> tests: Add test case for empty 'network' cdrom
>
> src/conf/domain_conf.c | 4 +++
> ...m-empty-network-invalid.x86_64-latest.args | 34 +++++++++++++++++++
> .../disk-cdrom-empty-network-invalid.xml | 30 ++++++++++++++++
> tests/qemuxml2argvtest.c | 1 +
> ...om-empty-network-invalid.x86_64-latest.xml | 34 +++++++++++++++++++
> tests/qemuxml2xmloutdata/disk-source-pool.xml | 2 +-
> tests/qemuxml2xmltest.c | 1 +
> 7 files changed, 105 insertions(+), 1 deletion(-)
> create mode 100644 tests/qemuxml2argvdata/disk-cdrom-empty-network-invalid.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-cdrom-empty-network-invalid.xml
> create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-empty-network-invalid.x86_64-latest.xml
>
I agree that this is not pretty, but I don't think there's a better way.
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
Michal
More information about the libvir-list
mailing list