[libvirt] [RFC] Accepting PRs/MRs for libvirt on GitHub/GitLab

[Pavel Hrdina]

On Thu, Oct 17, 2019 at 07:57:46AM +0200, Peter Krempa wrote:
> On Wed, Oct 16, 2019 at 17:08:20 +0100, Daniel Berrange wrote:
> > On Wed, Oct 16, 2019 at 05:03:31PM +0200, Ján Tomko wrote:
> > > On Wed, Oct 16, 2019 at 02:22:56PM +0200, Andrea Bolognani wrote:
> 
> [...]
> 
> > > Here it deviates from the usual mailing list workflow where the patch
> > > has (in theory) a chance to be seen by all the developers.
> > > 
> > > But given that the requests will probably
> > > a) be close to trivial
> > > b) seen by a group of developers, not just one
> > 
> > I wouldn't expect the changes to be trivial. Current stuff
> > is trivial largely because we tell people not to open merge
> > requests. If we adopt use of web based review, then expect
> 
> I'd still want the message we'll put out to encourage them using e-mail.
> 
> > people to submit non-trivial patches. I would do so myself
> > for example. Thus I think we must make a clean switchover
> > from email to a single web based tool.
> 
> I disagree. There is nothing really appealing to me in any of the web
> based frontends for git.
> 
> The user interface of them is designed to be flashy but that really
> hurts usability of git. We get cool icons but in return we must pay with
> always-online connection, loading bars if you click anywhere and the
> general necessity to interact with the browser which requires a lot of
> mousing around.
> 
> The commenting interface on individual patches is very poor given what
> email allows you and in many cases it's hard to access older versions
> after a pull-request is force-pushed.

I believe that most of us agree on this point and if we have a tool that
will bring the review process closer to the email workflow we can
actually try using it.

Anyway, there is another email from Dan which summarizes it better and
offers a reasonable approach which can answer some of the concerns
you've addressed in this reply so I would suggest that we continue
discussion based on that email [1] to not have multiple threads.

Pavel

[1] <https://www.redhat.com/archives/libvir-list/2019-October/msg01034.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191017/b0304d19/attachment-0001.sig>