[libvirt] [PATCH RFC 18/40] conf: snapshot: Remove 'update_current' parameter from virDomainSnapshotRedefinePrep

Peter Krempa pkrempa at redhat.com
Fri Oct 18 16:11:03 UTC 2019


The variable is unused so we can drop it.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/conf/snapshot_conf.c | 1 -
 src/conf/snapshot_conf.h | 1 -
 src/qemu/qemu_driver.c   | 2 +-
 src/test/test_driver.c   | 2 +-
 4 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c
index ec47e14955..a1d14a480a 100644
--- a/src/conf/snapshot_conf.c
+++ b/src/conf/snapshot_conf.c
@@ -989,7 +989,6 @@ virDomainSnapshotRedefinePrep(virDomainObjPtr vm,
                               virDomainSnapshotDefPtr *defptr,
                               virDomainMomentObjPtr *snap,
                               virDomainXMLOptionPtr xmlopt,
-                              bool *update_current G_GNUC_UNUSED,
                               unsigned int flags)
 {
     virDomainSnapshotDefPtr def = *defptr;
diff --git a/src/conf/snapshot_conf.h b/src/conf/snapshot_conf.h
index 7e2ffa9d60..b0b52e6a34 100644
--- a/src/conf/snapshot_conf.h
+++ b/src/conf/snapshot_conf.h
@@ -136,7 +136,6 @@ int virDomainSnapshotRedefinePrep(virDomainObjPtr vm,
                                   virDomainSnapshotDefPtr *def,
                                   virDomainMomentObjPtr *snap,
                                   virDomainXMLOptionPtr xmlopt,
-                                  bool *update_current,
                                   unsigned int flags);

 int virDomainSnapshotRedefineValidate(virDomainSnapshotDefPtr def,
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index e908331a93..501c909e49 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -15918,7 +15918,7 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
     if (redefine) {
         if (virDomainSnapshotRedefinePrep(vm, &def, &snap,
                                           driver->xmlopt,
-                                          &update_current, flags) < 0)
+                                          flags) < 0)
             goto endjob;
     } else {
         /* Easiest way to clone inactive portion of vm->def is via
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ab7e5fc02a..feada30a4b 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -8614,7 +8614,7 @@ testDomainSnapshotCreateXML(virDomainPtr domain,
     if (redefine) {
         if (virDomainSnapshotRedefinePrep(vm, &def, &snap,
                                           privconn->xmlopt,
-                                          &update_current, flags) < 0)
+                                          flags) < 0)
             goto cleanup;
     } else {
         if (!(def->parent.dom = virDomainDefCopy(vm->def,
-- 
2.21.0




More information about the libvir-list mailing list