[libvirt] [PATCH 68/75] virpcimock: Make @fakerootdir static

Michal Privoznik mprivozn at redhat.com
Tue Oct 22 13:58:12 UTC 2019


Since we are not passing the @fakerootdir variable to any inline function
anymore, we can make the variable static.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tests/virpcimock.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/tests/virpcimock.c b/tests/virpcimock.c
index 0d502db68c..7e4554a1dc 100644
--- a/tests/virpcimock.c
+++ b/tests/virpcimock.c
@@ -39,11 +39,7 @@ static int (*real_close)(int fd);
 static DIR * (*real_opendir)(const char *name);
 static char *(*real_virFileCanonicalizePath)(const char *path);
 
-/* Don't make static, since it causes problems with clang
- * when passed as an arg to virAsprintf()
- * vircgroupmock.c:462:22: error: static variable 'fakesysfsdir' is used in an inline function with external linkage [-Werror,-Wstatic-in-inline]
- */
-char *fakerootdir;
+static char *fakerootdir;
 
 /* To add a new mocked prefix in virpcimock:
  * - add the prefix here as a define to make it easier to track what we
-- 
2.21.0




More information about the libvir-list mailing list