[libvirt] [PATCH 0/7] net/qemu: move vlan/bandwidth validation out of network driver

Laine Stump laine at redhat.com
Wed Oct 23 01:24:13 UTC 2019


As usual, the first 6 patches are just torquing stuff around to make
the last patch simple (except that patch 1 makes interface validation
errors more useful). 2-5 are just converting a bunch of accessor
functions to tak/return const pointers, since that's what's available
in the places where I wanted to use them.

This does actually fix a documented bug:

  https://bugzilla.redhat.com/1741121

(that one is about vlan tag validation. There may also be one about
bandwidth, but I didn't see it right away, so I gave up, as is my
custom).

Laine Stump (7):
  qemu: add mac address to error messages in
    qemuDomainValidateActualNetDef
  conf: make virDomainNetGetActualVlan arg/return val const
  conf: make virDomainNetGetActualBandwidth arg/return value const
  conf: return a const from virDomainNetGetActualVirtPortProfile
  conf: change args/return values of remaining virDomainNetGetActual*()
    to const
  conf: add hypervisor agnostic, domain start-time, validation function
    for NetDef
  net/qemu: move vlan/bandwidth validation out of network driver

 src/conf/domain_conf.c               | 78 ++++++++++++++++++++++++----
 src/conf/domain_conf.h               | 21 ++++----
 src/conf/netdev_bandwidth_conf.c     |  2 +-
 src/conf/netdev_bandwidth_conf.h     |  2 +-
 src/conf/netdev_vport_profile_conf.c |  2 +-
 src/conf/netdev_vport_profile_conf.h |  2 +-
 src/libvirt_private.syms             |  1 +
 src/libxl/libxl_conf.c               |  6 +--
 src/libxl/libxl_domain.c             |  4 ++
 src/libxl/libxl_driver.c             |  4 ++
 src/libxl/xen_common.c               |  4 +-
 src/lxc/lxc_driver.c                 |  8 ++-
 src/lxc/lxc_process.c                | 16 +++---
 src/network/bridge_driver.c          | 37 -------------
 src/qemu/qemu_command.c              |  2 +-
 src/qemu/qemu_domain.c               | 35 ++++++++-----
 src/qemu/qemu_hotplug.c              |  6 +--
 src/qemu/qemu_migration_cookie.c     |  2 +-
 src/qemu/qemu_process.c              |  2 +-
 src/util/virhostdev.c                |  8 +--
 src/util/virnetdev.c                 |  4 +-
 src/util/virnetdev.h                 |  2 +-
 src/util/virnetdevbandwidth.c        |  6 +--
 src/util/virnetdevbandwidth.h        |  4 +-
 src/util/virnetdevmacvlan.c          | 20 +++----
 src/util/virnetdevmacvlan.h          | 10 ++--
 src/util/virnetdevmidonet.c          |  4 +-
 src/util/virnetdevmidonet.h          |  4 +-
 src/util/virnetdevopenvswitch.c      |  8 +--
 src/util/virnetdevopenvswitch.h      |  6 +--
 src/util/virnetdevtap.c              | 12 ++---
 src/util/virnetdevtap.h              | 12 ++---
 src/util/virnetdevvportprofile.c     | 12 ++---
 src/util/virnetdevvportprofile.h     | 12 ++---
 tests/bhyvexml2argvmock.c            |  4 +-
 35 files changed, 206 insertions(+), 156 deletions(-)

-- 
2.21.0




More information about the libvir-list mailing list