[libvirt] [PATCH RFC 26/40] qemu: checkpoint: Use qemuMonitorTransactionBitmapMergeSourceAddBitmap

[Ján Tomko]

On Fri, Oct 18, 2019 at 06:11:11PM +0200, Peter Krempa wrote:
>Use the new helper in qemuCheckpointDiscard rather than constructing the
>array manually.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_checkpoint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c
>index 6a272f9dab..937d9d6b3e 100644
>--- a/src/qemu/qemu_checkpoint.c
>+++ b/src/qemu/qemu_checkpoint.c
>@@ -173,7 +173,7 @@ qemuCheckpointDiscard(virQEMUDriverPtr driver,
>                     if (!(arr = virJSONValueNewArray()))
>                         return -1;
>
>-                    if (virJSONValueArrayAppendString(arr, disk->bitmap) < 0)
>+                    if (qemuMonitorTransactionBitmapMergeSourceAddBitmap(arr, node, disk->bitmap) < 0)
>                         return -1;

This would look better with less indentation.

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191024/fbbf8fb4/attachment-0001.sig>