[libvirt] [PATCH 09/19] tests: virbuffer: Remove unused test data struct

Peter Krempa pkrempa at redhat.com
Thu Oct 24 13:56:27 UTC 2019


The DO_TEST macro initializes 'struct testInfo' but it's not used by any
of the tests. Remove it.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 tests/virbuftest.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/tests/virbuftest.c b/tests/virbuftest.c
index 21b6295bb3..064b3e96b4 100644
--- a/tests/virbuftest.c
+++ b/tests/virbuftest.c
@@ -9,10 +9,6 @@

 #define VIR_FROM_THIS VIR_FROM_NONE

-struct testInfo {
-    int doEscape;
-};
-
 static int testBufAutoIndent(const void *data G_GNUC_UNUSED)
 {
     virBuffer bufinit = VIR_BUFFER_INITIALIZER;
@@ -404,18 +400,17 @@ mymain(void)
     int ret = 0;


-#define DO_TEST(msg, cb, data) \
+#define DO_TEST(msg, cb) \
     do { \
-        struct testInfo info = { data }; \
-        if (virTestRun("Buf: " msg, cb, &info) < 0) \
+        if (virTestRun("Buf: " msg, cb, NULL) < 0) \
             ret = -1; \
     } while (0)

-    DO_TEST("Auto-indentation", testBufAutoIndent, 0);
-    DO_TEST("Trim", testBufTrim, 0);
-    DO_TEST("AddBuffer", testBufAddBuffer, 0);
-    DO_TEST("set indent", testBufSetIndent, 0);
-    DO_TEST("autoclean", testBufferAutoclean, 0);
+    DO_TEST("Auto-indentation", testBufAutoIndent);
+    DO_TEST("Trim", testBufTrim);
+    DO_TEST("AddBuffer", testBufAddBuffer);
+    DO_TEST("set indent", testBufSetIndent);
+    DO_TEST("autoclean", testBufferAutoclean);

 #define DO_TEST_ADD_STR(DATA, EXPECT) \
     do { \
-- 
2.21.0




More information about the libvir-list mailing list