[libvirt] [PATCH 1/7] util: purge all code for testing OOM handling

Ján Tomko jtomko at redhat.com
Mon Sep 2 13:40:17 UTC 2019


On Thu, Aug 29, 2019 at 07:02:44PM +0100, Daniel P. Berrangé wrote:
>The OOM handling requires special build time options which we never
>enable in our CI. Even once enabled the tests are incredibly slow and
>typically require manual inspection of the results to weed out false
>positives.
>
>Since there was previous agreement to switch to abort on OOM in libvirt
>code, there's no point continuing to keep the unused OOM testing code.
>
>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> configure.ac                      |  17 ---
> docs/docs.html.in                 |   3 -
> docs/internals/oomtesting.html.in | 213 ------------------------------
> src/libvirt_private.syms          |   4 -
> src/util/viralloc.c               | 111 ----------------
> src/util/viralloc.h               |   5 -
> tests/Makefile.am                 |   1 -
> tests/oomtrace.pl                 |  41 ------
> tests/qemuxml2argvtest.c          |  12 +-
> tests/testutils.c                 | 189 +-------------------------
> tests/testutils.h                 |   2 -
> tests/virfirewalltest.c           |  12 --
> 12 files changed, 6 insertions(+), 604 deletions(-)
> delete mode 100644 docs/internals/oomtesting.html.in
> delete mode 100755 tests/oomtrace.pl
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190902/967fcb75/attachment-0001.sig>


More information about the libvir-list mailing list